drivers: audio: sf32lb52x: audio codec driver #98701

ljq-ctrl · 2025-11-01T10:54:48Z

audio playback and capure, extend API in codec.h

ljq-ctrl · 2025-11-01T11:07:22Z

download code from github very very slow.
Encountered a git problem that cannot be solved
I close the following PR and recommit it refrence
https://docs.zephyrproject.org/latest/contribute/guidelines.html#contribution-workflow

the old PR is:
driver:audio: sf32lb52x:Add onchip codec driver for sf32lb52x platform #97906

drivers/audio/sf32lb_codec.h

JarmouniA · 2025-11-01T16:06:34Z

boards/sifli/sf32lb52_devkit_lcd/sf32lb52_devkit_lcd.yaml

  - uart
  - gpio
  - watchdog
+  - audio-codec


Suggested change

- audio-codec

- audio

it should be used as a tag for some test/sample, otherwise has no utility.
https://docs.zephyrproject.org/latest/develop/test/twister.html#board-configuration

Speaking of which, this driver has to be tested (or at least built) in CI.

boards/sifli/sf32lb52_devkit_lcd/sf32lb52_devkit_lcd.dts

drivers/audio/Kconfig.sf32lb

drivers/audio/sf32lb_codec.h

gmarull

Please make sure to not make unrelated changes into a big commit, split changes into chunks as needed. Also, make sure CI passes and do not open new PRs.

drivers/audio/sf32lb_codec.h

JarmouniA · 2025-11-29T10:31:54Z

samples/drivers/audio/codec/README.rst

@@ -0,0 +1,30 @@
+.. zephyr:code-sample:: codec
+   :name: codec


Suggested change

:name: codec

:name: audio codec

JarmouniA · 2025-11-29T10:32:11Z

samples/drivers/audio/codec/sample.yaml

+sample:
+  description: onchip audio codec example
+    application
+  name: codec


Suggested change

name: codec

name: audio codec

Addressed

ck-telecom · 2025-12-01T05:28:34Z

drivers/audio/sf32lb_codec.c

+
+	sys_set_bit(reg + CODEC_PLL_CFG2, AUDCODEC_PLL_CFG2_RSTB_Pos);
+
+#if AVDD_V18_ENABLE


It this should be configured in dts?

Not now. I will remove the #if

drivers/audio/sf32lb_codec.c

ck-telecom · 2025-12-01T05:33:10Z

drivers/audio/sf32lb_codec.c

+		key = irq_lock();
+		sys_set_bit(cfg->reg + CODEC_ADC_CH0_CFG, AUDCODEC_ADC_CH0_CFG_DMA_EN_Pos);
+		irq_unlock(key);


why need to disable the interrupt while writting this register?

There might be multiple thread to access to this register? configuration might be interrupted.

you should consider if there is 'race condition' from interface level or application level, not in register access level

ck-telecom · 2025-12-01T05:33:29Z

drivers/audio/sf32lb_codec.c

+		key = irq_lock();
+		sys_set_bit(cfg->reg + CODEC_DAC_CH0_CFG, AUDCODEC_DAC_CH0_CFG_DMA_EN_Pos);
+		irq_unlock(key);


ck-telecom · 2025-12-01T05:43:45Z

drivers/audio/sf32lb_codec.c

+
+	sys_write32(reg_val, reg + CODEC_DAC_CH0_CFG_EXT);
+
+	reg_val = FIELD_PREP(AUDCODEC_DAC_CH0_DEBUG_BYPASS_Msk, 0) |


It need to overwrite the value, so no read is needed

reg_val need initialized with 0 coz | operator

In this case, reg_val is composed, no 0 init needed.

ck-telecom · 2025-12-01T05:45:54Z

drivers/audio/sf32lb_codec.c

+
+static void config_rx_channel(uintptr_t reg, struct sf32lb_codec_adc_cfg *cfg)
+{
+	uint32_t reg_val;


reg_val need init?

No, it will be overwritten before it is used.

ck-telecom · 2025-12-01T05:46:20Z

drivers/audio/sf32lb_codec.c

+
+static void pll_turn_on(uintptr_t reg)
+{
+	uint32_t reg_val;


No, it will be overwritten before it is used.

reg_val need initialized with 0 coz | operator

In this case, reg_val is composed in next line. No need to init as 0.

ck-telecom · 2025-12-01T05:46:42Z

drivers/audio/sf32lb_codec.c

+	sys_set_bit(reg + CODEC_PLL_CFG3, AUDCODEC_PLL_CFG3_EN_SDM_Pos);
+	sys_set_bit(reg + CODEC_PLL_CFG4, AUDCODEC_PLL_CFG4_EN_CLK_DIG_Pos);
+
+	reg_val = FIELD_PREP(AUDCODEC_PLL_CFG1_R3_SEL_Msk, 3) |


It need to overwrite the value, so no read is needed

if NOT all bits overwrite, some bits is still ramdom, take care

I reviewed the FIELD_PREP related code, and fixed those need to clear first.

drivers/audio/sf32lb_codec.c

gmarull · 2025-12-01T09:17:55Z

drivers/dma/dma_sf32lb.c

+		LOG_ERR("start not possible with DMA enabled");
 		return 0;


return 0 when error?

gmarull · 2025-12-01T09:18:34Z

drivers/dma/dma_sf32lb.c

+	uint32_t cm0arx;
+
+	ret = check_dma_config(channel, config_dma, config);
+	if (ret) {


ret not boolean, use ret < 0

gmarull · 2025-12-01T09:19:10Z

drivers/dma/dma_sf32lb.c

 	}

+	if (config_dma->dest_data_size != config_dma->source_data_size) {
+		LOG_ERR("dest_data_size != source_data_size not support");


Destination and source sizes not equal

gmarull · 2025-12-01T09:19:42Z

drivers/dma/dma_sf32lb.c


-static int dma_sf32lb_config(const struct device *dev, uint32_t channel,
-			     struct dma_config *config_dma)
+static inline int check_dma_config(uint32_t channel, struct dma_config *config_dma,


why an extra inline? is it used anywhere else? if not please remove

gmarull · 2025-12-01T09:20:03Z

drivers/dma/dma_sf32lb.c

 #define DMAC_CBSR2     offsetof(DMAC_TypeDef, CBSR2)
 #define DMAC_CBSRX(n)  (DMAC_CBSR1 + (DMAC_CBSR2 - DMAC_CBSR1) * (n))
 #define DMAC_CSELR1    offsetof(DMAC_TypeDef, CSELR1)
 #define DMAC_CSELR2    offsetof(DMAC_TypeDef, CSELR2)


Improve commit description for f942b8b

gmarull · 2025-12-01T09:30:08Z

boards/sifli/sf32lb52_devkit_lcd/sf32lb52_devkit_lcd-pinctrl.dtsi

 		};
 	};

+	pa_power_default: pa_power_default {


gmarull · 2025-12-01T09:30:59Z

samples/drivers/audio/codec/README.rst

+.. zephyr:code-sample:: codec
+   :name: audio codec
+
+   mic to speaker loopback.


rename sample folder to a more descriptive name, e.g. mic_speaker_loopback?

It is not just loopback, it has playback function as well.

gmarull · 2025-12-01T09:31:54Z

samples/drivers/audio/codec/src/main.c

+#if DT_NODE_HAS_STATUS_OKAY(DT_NODELABEL(audcodec))
+	dev = DEVICE_DT_GET(DT_NODELABEL(audcodec));
+#else


this makes sample specific to SF32, please, rely on standard e.g. aliases to make sample portable.

audcodec is not SF32 specific, this is just a new audio device name

gmarull · 2025-12-01T09:32:15Z

samples/drivers/audio/codec/src/main.c

+	if (!device_is_ready(dev)) {
+		printk("codec device is not ready\n");
+		return -EBUSY;
+	}


device readiness needs to be done at the very beginning

gmarull · 2025-12-01T09:32:36Z

samples/drivers/audio/codec/src/main.c

+static uint8_t __aligned(4) pcm_16k[] = {
+	0x01, 0x00, 0xFE, 0x17, 0x55, 0x2C, 0xEB, 0x39, 0xB1, 0x3E, 0xEC, 0x39, 0x55, 0x2C, 0xFE,
+	0x17, 0x01, 0x00, 0x02, 0xE8, 0xAC, 0xD3, 0x15, 0xC6, 0x4F, 0xC1, 0x15, 0xC6, 0xAC, 0xD3,


why is data needed if sample is a mic loopback>?

The sample has 2 demos, one is playback, the other is loopback

drivers/audio/sf32lb_codec.c

drivers/dma/dma_sf32lb.c

drivers/audio/sf32lb_codec.c

boards/sifli/sf32lb52_devkit_lcd/sf32lb52_devkit_lcd.dts

ck-telecom · 2025-12-03T06:55:54Z

drivers/audio/sf32lb_codec.c

+static void pa_power_disable(const struct gpio_dt_spec *spec)
+{
+	/* configure PA power pin */
+	(void)gpio_pin_configure_dt(spec, GPIO_OUTPUT_LOW);


Suggested change

(void)gpio_pin_configure_dt(spec, GPIO_OUTPUT_LOW);

gpio_pin_configure_dt(spec, GPIO_OUTPUT_INACTIVE);

This pin is not LED, it has to be low to disable, high to enable PA.

ck-telecom · 2025-12-03T07:04:08Z

drivers/audio/sf32lb_codec.c

+static void pa_power_enable(const struct gpio_dt_spec *spec)
+{
+	/* configure PA power pin */
+	(void)gpio_pin_configure_dt(spec, GPIO_OUTPUT_HIGH);


Suggested change

(void)gpio_pin_configure_dt(spec, GPIO_OUTPUT_HIGH);

gpio_pin_configure_dt(spec, GPIO_OUTPUT_ACTIVE);

This pin is not LED, it has to be low to disable, high to enable PA.

Add callback of half complete in DMA processing, Fix DMA size bug. Signed-off-by: Gang He <[email protected]>

Add audio codec device tree information for sf32lb52x.dtsi Signed-off-by: Gang He <[email protected]>

Support audio device that has both input and output function. Signed-off-by: Gang He <[email protected]>

audio playback and capure, extend API in codec.h Signed-off-by: Gang He <[email protected]>

Add audio codec in board device tree, including PA control pin. Signed-off-by: Gang He <[email protected]>

Add audio loop back sample Signed-off-by: Gang He <[email protected]>

sonarqubecloud · 2025-12-04T06:50:30Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

zephyrbot added platform: SF32LB area: Boards/SoCs area: Devicetree Bindings area: Audio labels Nov 1, 2025

zephyrbot requested review from TomasBarakNXP, cameled, ck-telecom, gmarull, kv2019i, lgirdwood and lyakh November 1, 2025 10:56

zephyrbot assigned gmarull Nov 1, 2025

ljq-ctrl mentioned this pull request Nov 1, 2025

driver:audio: sf32lb52x:Add onchip codec driver for sf32lb52x platform #97906

Closed

ljq-ctrl force-pushed the codec branch from 483f0e5 to 7d7f1c0 Compare November 1, 2025 14:20

ljq-ctrl changed the title ~~driver:audio: sf32lb52x:Add onchip codec driver for sf32lb52x platfor…~~ drivers: audio: sf32lb52x: audio codec driver Nov 1, 2025

JarmouniA previously requested changes Nov 1, 2025

View reviewed changes

ljq-ctrl force-pushed the codec branch from 7d7f1c0 to ba8dedc Compare November 3, 2025 03:02

ljq-ctrl requested review from JarmouniA November 3, 2025 06:15

gmarull requested changes Nov 3, 2025

View reviewed changes

drivers/audio/sf32lb_codec.h Outdated Show resolved Hide resolved

ljq-ctrl force-pushed the codec branch 8 times, most recently from 9625992 to 4f8250e Compare November 4, 2025 04:10

ljq-ctrl requested a review from gmarull November 4, 2025 05:17

ljq-ctrl force-pushed the codec branch from 2eaaa0e to 0112374 Compare November 29, 2025 04:45

JarmouniA reviewed Nov 29, 2025

View reviewed changes

gangheivt force-pushed the codec branch from 0112374 to 1b8d077 Compare December 1, 2025 05:07

ck-telecom requested changes Dec 1, 2025

View reviewed changes

gangheivt force-pushed the codec branch 4 times, most recently from 9794b44 to 11858fe Compare December 1, 2025 08:10

gmarull requested changes Dec 1, 2025

View reviewed changes

gangheivt force-pushed the codec branch 3 times, most recently from aec9f04 to 9efd2c3 Compare December 2, 2025 03:09

ck-telecom requested changes Dec 2, 2025

View reviewed changes

drivers/audio/sf32lb_codec.c Outdated Show resolved Hide resolved

drivers/dma/dma_sf32lb.c Outdated Show resolved Hide resolved

ck-telecom requested changes Dec 2, 2025

View reviewed changes

drivers/audio/sf32lb_codec.c Outdated Show resolved Hide resolved

gangheivt force-pushed the codec branch 2 times, most recently from 5f203b9 to 5a0675b Compare December 3, 2025 00:08

ck-telecom requested changes Dec 3, 2025

View reviewed changes

boards/sifli/sf32lb52_devkit_lcd/sf32lb52_devkit_lcd.dts Show resolved Hide resolved

gangheivt force-pushed the codec branch from 5a0675b to 51e9deb Compare December 3, 2025 06:36

ck-telecom requested changes Dec 3, 2025

View reviewed changes

Gang He added 3 commits December 3, 2025 19:17

drivers: dma: Fix DMA driver for SF32LB chipset

e287463

Add callback of half complete in DMA processing, Fix DMA size bug. Signed-off-by: Gang He <[email protected]>

dts: Add audio codec device tree info for sf32lb52x

296a884

Add audio codec device tree information for sf32lb52x.dtsi Signed-off-by: Gang He <[email protected]>

include: zephyr: audio: Update audio codec interface

688d59c

Support audio device that has both input and output function. Signed-off-by: Gang He <[email protected]>

gangheivt force-pushed the codec branch from 51e9deb to 0c59501 Compare December 4, 2025 03:17

Gang He added 3 commits December 3, 2025 22:14

drivers: audio: sf32lb52x: Add audio codec driver

a9788f0

audio playback and capure, extend API in codec.h Signed-off-by: Gang He <[email protected]>

board: sifli: sf32lb62_devkit_lcd: Add audio codec

9f00766

Add audio codec in board device tree, including PA control pin. Signed-off-by: Gang He <[email protected]>

samples: drivers: audio: Add codec loopback sample.

fe05329

Add audio loop back sample Signed-off-by: Gang He <[email protected]>

gangheivt force-pushed the codec branch from 0c59501 to fe05329 Compare December 4, 2025 06:15


		sys_set_bit(reg + CODEC_PLL_CFG2, AUDCODEC_PLL_CFG2_RSTB_Pos);

		#if AVDD_V18_ENABLE


		sys_write32(reg_val, reg + CODEC_DAC_CH0_CFG_EXT);

		reg_val = FIELD_PREP(AUDCODEC_DAC_CH0_DEBUG_BYPASS_Msk, 0) \|

	(void)gpio_pin_configure_dt(spec, GPIO_OUTPUT_LOW);
	gpio_pin_configure_dt(spec, GPIO_OUTPUT_INACTIVE);

drivers: audio: sf32lb52x: audio codec driver #98701

Are you sure you want to change the base?

drivers: audio: sf32lb52x: audio codec driver #98701

Conversation

ljq-ctrl commented Nov 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ljq-ctrl commented Nov 1, 2025

Uh oh!

Uh oh!

JarmouniA Nov 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gmarull left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gangheivt Dec 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ck-telecom Dec 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ljq-ctrl commented Nov 1, 2025 •

edited

Loading

JarmouniA Nov 1, 2025 •

edited

Loading

gangheivt Dec 1, 2025 •

edited

Loading

ck-telecom Dec 4, 2025 •

edited

Loading